Add redis 8.4-M01-pre to tested redis versions.#3790
Merged
petyaslavova merged 5 commits intomasterfrom Oct 6, 2025
Merged
Conversation
vladvildanov
approved these changes
Oct 6, 2025
vladvildanov
reviewed
Oct 6, 2025
| fail-fast: false | ||
| matrix: | ||
| redis-version: ['8.2.1-pre', '${{ needs.redis_version.outputs.CURRENT }}', '8.0.2' ,'7.4.4', '7.2.9'] | ||
| redis-version: ['8.4-M01-pre', '${{ needs.redis_version.outputs.CURRENT }}', '8.0.2' ,'7.4.4', '7.2.9'] |
Collaborator
There was a problem hiding this comment.
I think we shouldn't change 8.2 to 8.4 and instead support both. 8.4 is another version to support so instead we have to remove 7.4 and 7.2 as soon as they EOL
Collaborator
Author
There was a problem hiding this comment.
I found that into the image version that is marked as CURRENT, once a patch is released, the base version image gets updated/rebuilt. For example, when 8.2.1 has been released, the 8.2 image gets rebuilt to contain Redis server with version 8.2.1. So now when 8.2.2 is release the used CURRENT(which is 8.2) will automatically start using it for the tests.
I was wondering if it is time to remove at least 7.2, but decided to add this removal in an additional PR after discussing this internally ...
…pipeline is not skipping a test
petyaslavova
force-pushed
the
ps_add_redis_8.4-M01-pre_to_tested_redis_versions
branch
from
ef3cca2 to
ebd4812
Compare
petyaslavova
deleted the
ps_add_redis_8.4-M01-pre_to_tested_redis_versions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.